Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove optional arguments from NewProxyObject #444

Merged
merged 1 commit into from Dec 21, 2018

Conversation

@AnshulMalik
Copy link
Contributor

AnshulMalik commented Oct 20, 2018

Fixes #441


This change is Reviewable

@jdm
Copy link
Member

jdm commented Dec 21, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2018

📌 Commit ab8fc91 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2018

Testing commit ab8fc91 with merge 2afcfa4...

bors-servo added a commit that referenced this pull request Dec 21, 2018
remove optional arguments from NewProxyObject

Fixes #441

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/444)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 2afcfa4 to master...

@bors-servo bors-servo merged commit ab8fc91 into servo:master Dec 21, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@AnshulMalik AnshulMalik deleted the AnshulMalik:optional-args branch Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.