Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[#411] Add some tests for default-initialized roots #451
Conversation
|
I have merged these two methods together. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 21, 2018
[#411] Add some tests for default-initialized roots 1. At the current stage, I only completed the test code for JSVal; I need to know how to implement several other types of default values in order to complete all the test code. 2. The default value of JSVal's current implementation is undefined, so we should use the is_undefined() method to verify the result. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/451) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 22, 2018
[#411] Add some tests for default-initialized roots 1. At the current stage, I only completed the test code for JSVal; I need to know how to implement several other types of default values in order to complete all the test code. 2. The default value of JSVal's current implementation is undefined, so we should use the is_undefined() method to verify the result. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/451) <!-- Reviewable:end -->
|
|
|
This is my first code commit under the servo organization. This is a good start. Thank you very much for your patience! |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
longwusha commentedDec 21, 2018
•
edited by larsbergstrom
This change is