Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose IntoMutableHandle API. #455

Merged
merged 1 commit into from Jul 23, 2019
Merged

Expose IntoMutableHandle API. #455

merged 1 commit into from Jul 23, 2019

Conversation

@jdm
Copy link
Member

jdm commented Mar 22, 2019 •
edited by larsbergstrom

This change is Reviewable
@jdm
Expose IntoMutableHandle API.
Loading status checks…
c80f664
@jdm
Copy link
Member Author

jdm commented Mar 22, 2019

As far as I can tell not exposing this is just an oversight.
@jdm
Copy link
Member Author

jdm commented Apr 27, 2019

r? @asajeffrey
@jdm
Copy link
Member Author

jdm commented Jul 22, 2019

Ping @asajeffrey
@asajeffrey
Copy link
Member

asajeffrey commented Jul 22, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 22, 2019

📌 Commit c80f664 has been approved by asajeffrey
bors-servo added a commit that referenced this pull request Jul 23, 2019
@bors-servo
Auto merge of #455 - jdm:intomut, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
464b4c4 
Expose IntoMutableHandle API.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/455)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

⌛ Testing commit c80f664 with merge 464b4c4...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

💔 Test failed - checks-travis
@CYBAI
Copy link
Contributor

CYBAI commented Jul 23, 2019 •
edited

@bors-servo retry

(Can bors retry travis? 🤔)

Caused by:
  [6] Couldn't resolve host name (Could not resolve host: crates.io)
/Users/travis/.travis/functions: line 524: 83321 Terminated: 15          travis_jigger "${!}" "${timeout}" "${cmd[@]}"
The command "CCACHE=$(which ccache) travis_wait cargo build --verbose $FEATURES" exited with 101.
@jdm
Copy link
Member Author

jdm commented Jul 23, 2019

It's easier to restart the single failed job in the travis interface.
@CYBAI
Copy link
Contributor

CYBAI commented Jul 23, 2019

hmm, seems I cannot restart the job for Travis in this repo 😖
bors-servo added a commit that referenced this pull request Jul 23, 2019
@bors-servo
Auto merge of #455 - jdm:intomut, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
36d53b8 
Expose IntoMutableHandle API.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/455)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

⌛ Testing commit c80f664 with merge 36d53b8...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: asajeffrey
Pushing 36d53b8 to master...
@bors-servo bors-servo merged commit c80f664 into servo:master Jul 23, 2019
2 of 3 checks passed
2 of 3 checks passed
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @asajeffrey @bors-servo @CYBAI
You can’t perform that action at this time.