Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to SpiderMonkey 67 #465
Merged
+110
−51
Conversation
|
Mostly this looks good, the functions which |
src/jsglue.cpp
Outdated
| } | ||
|
|
||
| virtual void runJobs(JSContext* cx) { | ||
| MOZ_ASSERT("runJobs should not be invoked"); |
This comment has been minimized.
This comment has been minimized.
asajeffrey
Jun 21, 2019
Member
Hmm, this is a bit annoying, I can imagine it being triggered in future versions of SM/Servo.
| private: | ||
| virtual js::UniquePtr<SavedJobQueue> saveJobQueue(JSContext* cx) { | ||
| MOZ_ASSERT("saveJobQueue should not be invoked"); | ||
| return nullptr; |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 26, 2019
Upgrade to SpiderMonkey 67 Depends on servo/mozjs#186. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/465) <!-- Reviewable:end -->
|
|
|
Retrying the single failed job. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJun 17, 2019
•
edited by larsbergstrom
Depends on servo/mozjs#186.
This change is