Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchange the slot count to match the spidermonkey defintion #479
Conversation
right now the slot count is `2 + 38` in the spider monkey fork. this PR changes it to match the C++ definition.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2019
change the slot count to match the spidermonkey defintion right now the slot count is `2 + 38` in the spider monkey fork. this PR changes it to match the C++ definition. The definition in C++: https://github.com/servo/mozjs/blob/dd175ee73a179ce218286c4be4ab80e1a75348be/mozjs/js/public/Class.h#L841 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/479) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
r-52 commentedOct 4, 2019
•
edited by larsbergstrom
right now the slot count is
2 + 38in the spider monkey fork. this PR changes it to match the C++ definition.The definition in C++: https://github.com/servo/mozjs/blob/dd175ee73a179ce218286c4be4ab80e1a75348be/mozjs/js/public/Class.h#L841
This change is