Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix deprecation warnings for `try!` and dyn traits #480
+6
−6
Conversation
this commit fixes some deprecation warnings that are caused by the old `try!`. Every part is replaced with the `?` operator. At one part the compiler mentioned the deprecation: `trait objects without an explicit `dyn` are deprecated` which is also replaced.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2019
fix deprecation warnings for `try!` and dyn traits this commit fixes some deprecation warnings that are caused by the old `try!`. Every part is replaced with the `?` operator. At one part the compiler mentioned the deprecation: ```bash trait objects without an explicit `dyn` are deprecated ``` which is also replaced. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/480) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2019
fix deprecation warnings for `try!` and dyn traits this commit fixes some deprecation warnings that are caused by the old `try!`. Every part is replaced with the `?` operator. At one part the compiler mentioned the deprecation: ```bash trait objects without an explicit `dyn` are deprecated ``` which is also replaced. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/480) <!-- Reviewable:end -->
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
r-52 commentedOct 5, 2019
•
edited by larsbergstrom
this commit fixes some deprecation warnings that are caused by the old
try!. Every part is replaced with the?operator. At one part the compiler mentioned the deprecation:trait objects without an explicit `dyn` are deprecatedwhich is also replaced.
This change is