Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a basic readme with an example on how to eval a result in js #481

Closed
wants to merge 1 commit into from

Conversation

@r-52
Copy link
Contributor

r-52 commented Oct 5, 2019

this PR introduces new blocks in the readme to showcase how to eval
a string to a value.

BTW: the minor version is based on the latest published crates.io version. Should this be changed to the latest master? Or is a new release planned?


This change is Reviewable

this pr introduces new blocks in the readme to showcase how to eval
a string to a value.
@jdm
Copy link
Member

jdm commented Oct 7, 2019

We are no longer able to publish the mozjs crate (and transitively the rust-mozjs crate) to crates.io because of rust-lang/cargo#6917. The documentation should not recommend using a published version because of this.

@r-52
Copy link
Contributor Author

r-52 commented Oct 7, 2019

@jdm do you think it makes sense to switch from the version-number-scheme to a Git-url? Or should this be removed?

@jhwgh1968
Copy link
Contributor

jhwgh1968 commented Jan 18, 2020

Hi @romankl, I wish I had seen your PR sooner. I created #489 in December, which does something similar in the crate doc string. The main difference is that mine refers to the online User Guide, and specifically translates two example blocks.

Your code helped me when I was tripping over some things in the Rust API. Could we merge our code somehow?

@jdm
Copy link
Member

jdm commented Jan 23, 2020

My fear with adding this code to the readme in this form is that it will potentially get out of date when we upgrade spidermonkey, since it's not automatically compiled and validated in CI. I would rather add an examples directory that we can check with cargo build --all-examples.

@r-52 r-52 closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.