Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThrow when failing to convert sequence inner values #485
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2019
Throw when failing to convert sequence inner values Returning `Ok(ConversionResult::Failure)` allows the code to try other conversion in a union type, but [per the spec there is no such failover](https://heycam.github.io/webidl/#es-union) given that the type is iterable. For servo/servo#24406.
|
|
|
Oops, I just found that maybe we need a version update for publishing a new version to include this patch? |
|
We don't really publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
saschanaz commentedOct 16, 2019
•
edited
Returning
Ok(ConversionResult::Failure)allows the code to try other conversion in a union type, but per the spec there is no such failover given that the type is iterable.For servo/servo#24406.