De @mut the bindings.

[jdm]

No description provided.

[metajack]

This API seems odd. Why limit it to statics?

[jdm]

The string needs to stay alive forever, basically.

[metajack]

It used to be owned.

If you transmute a ~str to something raw it won't be finalized unless you transmute it back and let it drop.

Also, now that I'm noticing, why is this all i8 instead of u8? :)

[jdm]

It used to be owned when passed in, but then we stored it forever inside the name pool. I hate everything about that and it was awful; all serious JSAPI work I've done and seen uses static classes and strings everywhere. The u8/i8 thing is the libc::c_char is defined as *i8 for some reason.

[metajack]

If normal JSAPI code uses static strings, that sounds fine then. Carry on.

[metajack]

Same 'static thing here.

[jdm]

I don't actually know what the restrictions for the lifetime of the property name are for JS_DefineProperty. I'll take a look.

[metajack]

I don't like the statics. It seems pretty limiting, and it looks like there is some constraint I don't understand or this is just trying to save a clone or work around doing a transmute?

Looks fine otherwise.

[jdm]

Durr, awkward. This didn't actually merge before the other, but worked because it's a branch of the official repo.