This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
CompileOptionsWrapper::new should accept a &str instead of a C string pointer #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CYBAI
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
It would be good to describe what the issue is explicitly in PR name instead of FIxes issue 518.
For example, just same as the issue name, CompileOptionsWrapper::new should accept a &str instead of a C string pointer .
Besides, you can add Fixes #518 in PR description so that GitHub can close the issue automatically when this PR merged.
Other than these 2 points, this PR looks good to me! Thanks for your contribution!
nicoabie
changed the title
jdm
approved these changes
Jul 27, 2020
…lename Also changed the line parameter to u32 instead of c_int (to make the bits clearer)
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Updated CompileOptionsWrapper new method to receive a &str for the filename
Also changed the line parameter to u32 instead of c_int (to make the bits clearer)
Fixes #518