This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
/ rust-mozjs Public archive
CompileOptionsWrapper::new should accept a &str instead of a C string pointer #520
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Updated CompileOptionsWrapper new method to receive a &str for the filename
Also changed the line parameter to u32 instead of c_int (to make the bits clearer)