Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove the JSVal interfaces. #54
Merged
+184
−299
Conversation
|
Yes. Good. |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 9, 2014
Requires servo/rust-mozjs#54.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 10, 2014
Requires servo/rust-mozjs#54.
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Add AzDrawTargetFillGlyphs in azure_hl.rs
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Fix build under MSYS2/MINGW64 This is a set of changes needed to build mozjs under msys2/mingw64. Core changes: - Allow building with msys make - Don't strip "lib" prefix from library names - Use system nspr with correct lib names (nspr-config gives incorrect values) - Force using native win32 python instead of the mingw64/msys python I'm not really happy with these changes since these are all basically core m-c js files, and I don't think we could take some of these changes in m-c. But, the majority of changes are correct or are resolving deeper issues in the m-c build system (e.g. the need to use the native win32 python instead of the msys one). The ICU libprefix stuff can probably be resolved a different way, I just wasn't sure how to go about it. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/54) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…SVal); r=jdm Requires servo/rust-mozjs#54. Source-Repo: https://github.com/servo/servo Source-Revision: 654f3db29511d3b7b7a49a875b86a8538d111bcf UltraBlame original commit: 9f17560e80b9f61b7c62c16c00815b5d0e3b48b6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2019
…SVal); r=jdm Requires servo/rust-mozjs#54. Source-Repo: https://github.com/servo/servo Source-Revision: 654f3db29511d3b7b7a49a875b86a8538d111bcf UltraBlame original commit: 9f17560e80b9f61b7c62c16c00815b5d0e3b48b6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…SVal); r=jdm Requires servo/rust-mozjs#54. Source-Repo: https://github.com/servo/servo Source-Revision: 654f3db29511d3b7b7a49a875b86a8538d111bcf UltraBlame original commit: 9f17560e80b9f61b7c62c16c00815b5d0e3b48b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedMar 9, 2014
This duplicates some more knowledge of the JSVal representation into rust; I think that's fine, as the representation rarely changes, and this makes for cleaner and more efficient code until we have cross-language inlining.