Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIn Int32Value, cast to u32 before casting to u64. #56
+1
−1
Conversation
Casting to u64 directly is equivalent to first casting to i64, which does sign extension. For negative values, this fills the highest 32 bits with ones rather than the zeros we need.
jdm
added a commit
that referenced
this pull request
Mar 10, 2014
In Int32Value, cast to u32 before casting to u64.
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Stop using shared GL contexts and move to native OS surface sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedMar 10, 2014
Casting to u64 directly is equivalent to first casting to i64, which does
sign extension. For negative values, this fills the highest 32 bits with
ones rather than the zeros we need.