Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove GetReservedSlot and shadow code to support it. #57
Conversation
Merged
We don't currently use it in Servo, and we don't have static assertions to ensure the correctness of the shadow structures, so I believe it's better not to have the code at all.
This comment has been minimized.
This comment has been minimized.
jdm
commented on 533d156
Mar 24, 2014
|
r+ |
jdm
added a commit
that referenced
this pull request
Mar 24, 2014
Remove GetReservedSlot and shadow code to support it.
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Warning police
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Add a travis config. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/57) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedMar 14, 2014
We don't currently use it in Servo, and we don't have static assertions to
ensure the correctness of the shadow structures, so I believe it's better
not to have the code at all.