Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRust 20140224b #58
Merged
Rust 20140224b #58
Conversation
js.rc
Outdated
| @@ -126,10 +126,10 @@ pub unsafe fn JS_SET_RVAL(_cx: *JSContext, vp: *JSVal, v: JSVal) { | |||
| #[inline(alwyas)] | |||
| pub unsafe fn JS_THIS_OBJECT(cx: *JSContext, vp: *mut JSVal) -> *JSObject { | |||
| let r = | |||
| if (*ptr::offset(&*vp, 1)).is_primitive() { | |||
| if (*(&*vp.offset(1))).is_primitive() { | |||
This comment has been minimized.
This comment has been minimized.
| @@ -178,7 +178,8 @@ mod shadow { | |||
|
|
|||
| #[inline(always)] | |||
| pub unsafe fn fixedSlots(&self) -> *JSVal { | |||
| (ptr::offset(ptr::to_unsafe_ptr(&self), 1)) as *JSVal | |||
| let x: *JSVal = cast::transmute(&self); | |||
| (x.offset(1)) as *JSVal | |||
This comment has been minimized.
This comment has been minimized.
Ms2ger
Mar 18, 2014
Collaborator
I'm not at all convinced this is correct, but I'm removing it in #57, so it's fine.
|
Comment about removing the r? @Ms2ger |
|
r+ |
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
QuartzSupport and header changes for OS X.
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Move to travis for homu. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/58) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedMar 18, 2014
r? @metajack