Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android support #63

Merged
merged 2 commits into from Apr 1, 2014
Merged

Android support #63

merged 2 commits into from Apr 1, 2014

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 1, 2014

  1. Add dylib generation
  2. Address linker issues on Android (i.e., #[link] is not emitting fully-named dependencies in the ELF header, requiring us to use #[link_name] in order to properly find and load all dependencies the .so file has)

r? @jdm @metajack

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Apr 1, 2014

@jdm @Ms2ger Does this work for you guys?

@jdm

This comment has been minimized.

Copy link

jdm commented on 4da979f Apr 1, 2014

r+

jdm added a commit that referenced this pull request Apr 1, 2014
@jdm jdm merged commit 516d5e0 into servo:master Apr 1, 2014
tschneidereit pushed a commit to tschneidereit/rust-mozjs that referenced this pull request Aug 26, 2017
Cherry-pick https://hg.mozilla.org/mozilla-central/rev/734e468e8274

Bring it from upstream to fix an intermittent build break.
Fixes servo#8416

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/63)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.