Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix accidental shadowing of js_GetErrorMessage #69
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on 85bfc63
Apr 11, 2014
|
r+ |
jdm
added a commit
that referenced
this pull request
Apr 11, 2014
Fix accidental shadowing of js_GetErrorMessage
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Upgrade to latest Rust.
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Backport fix for bug 1039986 https://bugzilla.mozilla.org/show_bug.cgi?id=1039986 Needed to fix the prototype inheritance chain in Servo. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/69) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedApr 11, 2014
jsglue.cpp defines a function with the same name of the jsapi function it tries to wrap, causing a probable infinite loop.