Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWork around dynamic linking problems on Android #70
Conversation
This appears to fix an intermittent "symbol not found error" from dlopen on Android.
|
r? @jdm |
This comment has been minimized.
This comment has been minimized.
jdm
commented on dff919a
Apr 12, 2014
|
r+ |
jdm
added a commit
that referenced
this pull request
Apr 12, 2014
Work around dynamic linking problems on Android
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Link expat on Linux (needed for in-tree fontconfig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedApr 12, 2014
This fixes a "symbol not found error" from dlopen on Android. However, I don't fully understand the underlying cause of the bug or why this fixes it. I think it might be related to a change in the order of linker arguments emitted by rustc, possibly related to servo/rust-fontconfig#12.