Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd gczeal and more jsval helpers. #71
Merged
Conversation
jsval.rs
Outdated
| } | ||
|
|
||
| pub fn trace_kind(&self) -> u32 { | ||
| assert!(self.is_gcthing()); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdm
Apr 14, 2014
Author
Member
What's your concern, precisely? These are direct ports of the Gecko versions.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Updated. |
|
r+ |
Ms2ger
added a commit
that referenced
this pull request
Apr 14, 2014
Add gczeal and more jsval helpers.
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Fix fontconfig / expat link order
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Fix build for win32, remove --enable-gczeal that snuck back in For some reason, gcc isn't generating public symbols for setTracingLocation if they're defined inline in the class declaration in the header. There's probably an attribute we could apply or something, but this was the simplest way to get this to work. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/71) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 13, 2014
Needed for servo/servo#2101.