Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce a ThrowTypeError function. #72
Closed
+24
−0
Conversation
|
Why does all this need to be in C++? It all looks like code that could either live in the Rust side or even in bindings/utils.rs. |
|
Do you have a way to put a *c_char in a static struct? |
static cstr: [u8, ..3] = ['h' as u8, 'i' as u8, 0];
static whatever: CStruct = CStruct { thing: &cstr as *u8 as *c_char }; |
|
That's not scarier than the C++ at all :) |
|
It can be slightly improved by cstr being [c_char, ..3], but yeah. I'd prefer to keep this in Rust code, regardless. |
|
We could also write a procedural macro like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedApr 19, 2014
No description provided.