Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid passing null for the string pointer to JS_EvaluateUCScript. #91
Conversation
For empty Vecs, Rust doesn't allocate a backing storage and instead sets the pointer to null. However, TokenStream::TokenBuf uses null as a poison value, leading to assertion failures when passing in null into the JS parser.
jdm
added a commit
that referenced
this pull request
Jul 13, 2014
Avoid passing null for the string pointer to JS_EvaluateUCScript.
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Upgrade Rust.
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Small update to upgrading instructions r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/91) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedJul 13, 2014
For empty Vecs, Rust doesn't allocate a backing storage and instead sets the
pointer to null. However, TokenStream::TokenBuf uses null as a poison value,
leading to assertion failures when passing in null into the JS parser.