Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch to threadsafe builds. #92
Merged
Conversation
In order to support threadsafe builds (which are necessary for thread-safety assertions and which will become the only available configuration in future versions), we need to link to NSPR for threading primitives.
In threadsafe builds, we should enter a request whenever we call into SpiderMonkey. The JSAutoRequest class makes that simpler.
Consumers should be using native rather than green tasks, to avoid calling into the same JSRuntime from multiple OS threads. For native tasks, SpiderMonkey can figure out the correct stack bounds for itself. Rust, on the other hand, apparently cannot; the existing code leads to crashes during conservative stack marking.
Ms2ger
added a commit
that referenced
this pull request
Aug 3, 2014
The Servo changes to move the script task to a native task are not progressing as fast as hoped, so these changes should be temporarily reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedJul 24, 2014
No description provided.