Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to threadsafe builds. #92

Merged
merged 3 commits into from Jul 24, 2014
Merged

Switch to threadsafe builds. #92

merged 3 commits into from Jul 24, 2014

Commits on Jul 24, 2014

  1. Link NSPR. 

    In order to support threadsafe builds (which are necessary for thread-safety
assertions and which will become the only available configuration in future
versions), we need to link to NSPR for threading primitives.
    @Ms2ger
    Ms2ger committed Jul 24, 2014
    06113f8

  2. Implement JSAutoRequest. 

    In threadsafe builds, we should enter a request whenever we call into
SpiderMonkey. The JSAutoRequest class makes that simpler.
    @Ms2ger
    Ms2ger committed Jul 24, 2014
    c61450f

  3. Remove the GC callback. 

    Consumers should be using native rather than green tasks, to avoid calling
into the same JSRuntime from multiple OS threads.

For native tasks, SpiderMonkey can figure out the correct stack bounds for
itself. Rust, on the other hand, apparently cannot; the existing code leads to
crashes during conservative stack marking.
    @Ms2ger
    Ms2ger committed Jul 24, 2014
    ecec92c
You can’t perform that action at this time.