Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd 'vertical-align' #27
Merged
+55
−1
Conversation
netsurfcss.rc
Outdated
|
|
||
| impl CssVerticalAlignValue { | ||
| pub fn new(type_: css_vertical_align_e, length: css_fixed, unit: css_unit) -> CssVerticalAlignValue { | ||
| if type_ == CSS_VERTICAL_ALIGN_INHERIT { |
This comment has been minimized.
This comment has been minimized.
metajack
Aug 19, 2013
Contributor
This needs to be a match. It will eliminate the final else case and the compiler will enforce that all cases are handled.
|
Looks good aside from needing to change |
+ use 'match' instead of 'if'
|
@metajack Thanks for the comment. I changed |
This comment has been minimized.
This comment has been minimized.
metajack
commented on bb3b55b
Aug 20, 2013
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
june0cho commentedAug 18, 2013
No description provided.