Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded glIs* #20
Merged
Added glIs* #20
+42
−0
Conversation
added 2 commits
Apr 20, 2013
|
A quick pick through the other functions shows that they take bools, not GLboolean. I think we should return bools as well. I can see no reason not to do so. Otherwise, this all looks good. |
|
Done, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeaye commentedApr 20, 2013
They're currently returning GLboolean, which is actually a u8. This is how the ll bindings expose them, so I kept it that way, but it'd be nice to just have them return Rust booleans. The current syntax looks something like:
and it'd just flow better as:
Let me know what you think.
Cheers,
Jeaye