Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added glIs* #20

Merged
merged 3 commits into from Apr 20, 2013
Merged

Added glIs* #20

merged 3 commits into from Apr 20, 2013

Conversation

@jeaye
Copy link
Contributor

jeaye commented Apr 20, 2013

They're currently returning GLboolean, which is actually a u8. This is how the ll bindings expose them, so I kept it that way, but it'd be nice to just have them return Rust booleans. The current syntax looks something like:

if gl::is_buffer(name) > 0
{ ... }

and it'd just flow better as:

if gl::is_buffer(name)
{ ... }

Let me know what you think.

Cheers,
Jeaye

@metajack
Copy link
Contributor

metajack commented Apr 20, 2013

A quick pick through the other functions shows that they take bools, not GLboolean. I think we should return bools as well. I can see no reason not to do so.

Otherwise, this all looks good.

@jeaye
Copy link
Contributor Author

jeaye commented Apr 20, 2013

Done, thanks.

metajack added a commit that referenced this pull request Apr 20, 2013
@metajack metajack merged commit bc01e4c into servo:master Apr 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.