Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd GL_TRUE and GL_FALSE #21
Merged
+4
−0
Conversation
|
I think you want to use c_uchar, not c_int. |
|
Why not Rust's booleans? The wrapper functions tend to take those instead, so making gl::TRUE be a c_int or even c_uchar is going to make some code more complex than it needs to be. |
|
For the wrapped functions, you will just pass true and false since they take bools. Since the low level stuff is also available for use, gl2::TRUE and gl2::FALSE should match the types of the externs I think. |
|
@chinmaygarde ping? |
|
@metajack Looks like this could use updated feedback now. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on c38a785
Jul 9, 2013
|
r+ |
metajack
added a commit
that referenced
this pull request
Jul 9, 2013
…0f3c2b56be47 Add GL_TRUE and GL_FALSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chinmaygarde commentedApr 20, 2013
An extremely minor addition