Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertex array gen/binding and glPolygonMode #24

Merged
merged 2 commits into from Apr 26, 2013

Conversation

@jeaye
Copy link
Contributor

jeaye commented Apr 25, 2013

No description provided.

@metajack
Copy link
Contributor

metajack commented Apr 25, 2013

Are either of these OpenGL ES 2 calls? I don't see glBindVertexArray or glGenVertexArrays in the spec: http://www.khronos.org/opengles/sdk/docs/man/

Do we want to add gl3.rs? @pcwalton thoguhts?

@jeaye
Copy link
Contributor Author

jeaye commented Apr 26, 2013

Hmm, yeah. That's up to you guys; I've just been adding what I need when I find something that's not there. If necessary, I just won't submit any more pull requests without first checking that it's in OpenGL ES 2.

@pcwalton
Copy link
Contributor

pcwalton commented Apr 26, 2013

Yeah, how about starting a gl3?

@metajack
Copy link
Contributor

metajack commented Apr 26, 2013

What was the original intent with this library. Now that I'm thinking about it, GL_BGRA and GL_UNSIGNED_INT_8_8_8_8_REV aren't in opengles 2 either (haven't checked 3). Perhaps it should be renamed rust-opengl and restructured to gl.rs (all functions), gles2 (export only stuff in gl.rs that is in ES 2.0), gles3.rs, etc. Then people could just use gl = opengl::gles2;

@metajack
Copy link
Contributor

metajack commented Apr 26, 2013

There's some precendent for this type of structure with core's posix stuff.

@pcwalton
Copy link
Contributor

pcwalton commented Apr 26, 2013

Yes, I think that would be a better method of organization. Honestly, the library was pretty hacked together—it could use a refactoring.

@metajack
Copy link
Contributor

metajack commented Apr 26, 2013

I'll merge this for now until we do the refactoring.

metajack added a commit that referenced this pull request Apr 26, 2013
Added vertex array gen/binding and glPolygonMode
@metajack metajack merged commit 82c8acc into servo:master Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.