Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate for android port. #66
Closed
Conversation
|
Looks fine except for the inconsistent names. |
aydinkim
commented
Dec 20, 2013
|
Recrack, you need to fix the naming rules have more consistency. |
aydinkim
commented
Dec 26, 2013
| @@ -365,6 +365,16 @@ pub type GLintptr = intptr_t; | |||
|
|
|||
| pub type GLsizeiptr = ssize_t; | |||
|
|
|||
| // GL info | |||
| pub static GL_VENDOR: c_uint = 0x1F00; | |||
This comment has been minimized.
This comment has been minimized.
|
r+ after the statics get renamed. |
aydinkim
commented
Dec 27, 2013
|
Recrack is on a leave. I'll do that instead of him. |
aydinkim
commented
Dec 27, 2013
|
It seems is duplicated. |
Merged
aydinkim
commented
Dec 27, 2013
|
Instead if this PR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
recrack commentedDec 19, 2013
This PR is for android port.