Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded vertex_attrib_pointer_u8 #9
Merged
Conversation
|
Yeah, it should be generic. This is fine though.
|
pcwalton
added a commit
that referenced
this pull request
Apr 1, 2013
Added vertex_attrib_pointer_u8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeaye commentedMar 31, 2013
I really feel like this code shouldn't be duplicated and the type param should just be exposed. Then we'd just have one vertex_attrib_pointer and specify the type. Maybe that's not very Rustic though; your call. If you're up for it, I'll make it a seperate PR.