Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertex_attrib_pointer_u8 #9

Merged
merged 1 commit into from Apr 1, 2013
Merged

Added vertex_attrib_pointer_u8 #9

merged 1 commit into from Apr 1, 2013

Conversation

@jeaye
Copy link
Contributor

jeaye commented Mar 31, 2013

I really feel like this code shouldn't be duplicated and the type param should just be exposed. Then we'd just have one vertex_attrib_pointer and specify the type. Maybe that's not very Rustic though; your call. If you're up for it, I'll make it a seperate PR.

@pcwalton
Copy link
Contributor

pcwalton commented Mar 31, 2013

Yeah, it should be generic. This is fine though.
On Mar 31, 2013 3:01 PM, "Jeaye" notifications@github.com wrote:

I really feel like this code shouldn't be duplicated and the type param
should just be exposed. Then we'd just have one vertex_attrib_pointer and
specify the type. Maybe that's not very Rustic though; your call. If you're

up for it, I'll make it a seperate PR.

You can merge this Pull Request by running

git pull https://github.com/Jeaye/rust-opengles master

Or view, comment on, or merge it at:

#9
Commit Summary

  • Added u8 vertex attrib

File Changes

  • M gl2.rshttps://github.com//pull/9/files#diff-0(15)

Patch Links:

pcwalton added a commit that referenced this pull request Apr 1, 2013
Added vertex_attrib_pointer_u8
@pcwalton pcwalton merged commit bfe1341 into servo:master Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.