Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to latest Rust #2
Conversation
|
Looks correct to me. |
metajack
commented
Jun 19, 2014
|
Shouldn't this be submitted upstream to sfackler/rust-phf? |
|
This is just pulling in upstream updates and undoing changes we had for our (older) compiler version AFAIK. |
metajack
commented
Jun 19, 2014
|
Ok. Usually you merge these after review. Do you not have a green button? |
|
I thought it was the PR author who merged submodules after review. Merging now. |
|
(note that there were merge conflicts, so its not entirely an upstream pull) -----Original Message----- Ok. Usually you merge these after review. Do you not have a green button? |
|
I don't have access to this repo, iirc. (this and a couple other mozilla-servo repos) -----Original Message----- I thought it was the PR author who merged submodules after review. Merging now. |
Manishearth commentedJun 18, 2014
I'm not entirely sure if this is correctly done. I had merge conflicts here, needs a closer look
(@glennw, could you help here? Thanks)