Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Rust #2

Merged
merged 5 commits into from Jun 19, 2014
Merged

Upgrade to latest Rust #2

merged 5 commits into from Jun 19, 2014

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jun 18, 2014

I'm not entirely sure if this is correctly done. I had merge conflicts here, needs a closer look

(@glennw, could you help here? Thanks)

@glennw
Copy link
Member

glennw commented Jun 18, 2014

Looks correct to me.

@metajack
Copy link

metajack commented Jun 19, 2014

Shouldn't this be submitted upstream to sfackler/rust-phf?

@glennw
Copy link
Member

glennw commented Jun 19, 2014

This is just pulling in upstream updates and undoing changes we had for our (older) compiler version AFAIK.

@metajack
Copy link

metajack commented Jun 19, 2014

Ok. Usually you merge these after review. Do you not have a green button?

@glennw
Copy link
Member

glennw commented Jun 19, 2014

I thought it was the PR author who merged submodules after review. Merging now.

glennw added a commit that referenced this pull request Jun 19, 2014
@glennw glennw merged commit 3b8834f into servo:servo Jun 19, 2014
@Manishearth
Copy link
Member Author

Manishearth commented Jun 19, 2014

(note that there were merge conflicts, so its not entirely an upstream pull)

-----Original Message-----
From: "Jack Moffitt" notifications@github.com
Sent: ‎6/‎20/‎2014 3:32 AM
To: "mozilla-servo/rust-phf" rust-phf@noreply.github.com
Cc: "Manish Goregaokar" manishsmail@gmail.com
Subject: Re: [rust-phf] Upgrade to latest Rust (#2)

Ok. Usually you merge these after review. Do you not have a green button?

Reply to this email directly or view it on GitHub.

@Manishearth
Copy link
Member Author

Manishearth commented Jun 19, 2014

I don't have access to this repo, iirc. (this and a couple other mozilla-servo repos)

-----Original Message-----
From: "glennw" notifications@github.com
Sent: ‎6/‎20/‎2014 3:36 AM
To: "mozilla-servo/rust-phf" rust-phf@noreply.github.com
Cc: "Manish Goregaokar" manishsmail@gmail.com
Subject: Re: [rust-phf] Upgrade to latest Rust (#2)

I thought it was the PR author who merged submodules after review. Merging now.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.