Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade Rust #5
Merged
Upgrade Rust #5
+984
−734
Conversation
Add a cargo config
We don't actually support anything beyond &'static str right now, but this will allow other keys in the future.
Update Cargo.toml to the new `plugin = true` flag
This implements @glennw's PR #5 to move the hashing code used by both phf and phf_mac into a module imported by both crates. It breaks the hard dependency of phf_mac on phf, which means phf doesn't have to be compiled for the host architecture as well as the target. It also means we can have a dev-dependency from phf to phf_mac for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJul 31, 2014
Merge upstream, fixed makefile, and backport a few fixes.