Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch to using png_jmpbuf to support older libpng versions. #1
+7
−12
Conversation
Recent libpng has png_jmpbuf `#define`d to a call to `png_set_longjmp_fn`, but this function did not exist in 1.2.x. This has a side effect of cleaning up the shim code a bit. We need libpng 1.2 support because Centos6 (used by Moz RelEng) only has 1.2.
jdm
added a commit
that referenced
this pull request
Jul 16, 2013
Switch to using png_jmpbuf to support older libpng versions.
globin
pushed a commit
to globin/rust-png
that referenced
this pull request
Oct 21, 2014
latest cargo + rustc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJul 16, 2013
Recent libpng has png_jmpbuf
#defined to a call topng_set_longjmp_fn, butthis function did not exist in 1.2.x. This has a side effect of cleaning up
the shim code a bit.
We need libpng 1.2 support because Centos6 (used by Moz RelEng) only has 1.2.