Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated error handling, crate-type and .gitignore #23

Merged
merged 2 commits into from Feb 12, 2014
Merged

Conversation

@Ogeon
Copy link
Contributor

Ogeon commented Feb 9, 2014

  • Error handling for IO functions are now using Result with error messages.
  • Results from write() and flush() in std::io::Writer are handled.
  • --lib has been changed to --crate-type=lib.
  • .rlib-files are now ignored by git.
@metajack
Copy link
Contributor

metajack commented Feb 11, 2014

It appears that the only new commits here are f829107 and 3711bc3. Can you remove the others and just leave these two?

You can do this with interactive rebase and just removing all the commits except those two.

@Ogeon
Copy link
Contributor Author

Ogeon commented Feb 11, 2014

Yes, I'm sorry about the messy commits. I will fix them soon.

@Ogeon
Copy link
Contributor Author

Ogeon commented Feb 11, 2014

It should be fixed now. I made a mistake while rebasing before and accidentally included my own duplicates. I hope the rest is ok.

@metajack

This comment has been minimized.

Copy link

metajack commented on 7a89146 Feb 12, 2014

r+

metajack added a commit that referenced this pull request Feb 12, 2014
Updated error handling, crate-type and .gitignore
@metajack metajack merged commit a24f48d into servo:master Feb 12, 2014
@metajack
Copy link
Contributor

metajack commented Feb 12, 2014

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.