Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upForce checking the color type before accessing pixels #42
+30
−27
Conversation
SimonSapin
changed the title
… by making pixels fields of the enum variants. This should help prevent bugs such as servo/servo#3154
This comment has been minimized.
This comment has been minimized.
|
r+ |
metajack
added a commit
that referenced
this pull request
Aug 26, 2014
Force checking the color type before accessing pixels
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this pull request
Aug 26, 2014
servo/rust-png#42 This does *not* fix the issue in servo#3154, but makes it fail!() instead of (maybe?) reading uninitalized memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedAug 26, 2014
… by making pixels fields of the enum variants.
This should help prevent bugs such as servo/servo#3154
[breaking-change]
r? @metajack
This is just proposing the idea for now. I haven’t tried to port Servo for this change.