Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExtract write_png function #53
Closed
+9
−4
Conversation
|
@metajack Any interest in merging this branch? |
|
I switched to https://github.com/PistonDevelopers/image for encoding png images, so I'm closing this pull request. If there's interest in this in the future, I can help get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dgraham commentedDec 9, 2014
A small refactoring that moves most of
store_pnginto a newwrite_pngfunction. This allows anyWriter, like stdout, to receive the png bytes. Nowstore_pngis responsible only for creating the file and delegates the png serialization towrite_png.