Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMany changes to libpng to avoid symbol collisions in the global namespace. #54
Conversation
|
r? @larsbergstrom or @metajack |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 521b29d
Jan 12, 2015
|
r+ |
metajack
added a commit
that referenced
this pull request
Jan 12, 2015
Many changes to libpng to avoid symbol collisions in the global namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJan 11, 2015
This changes how we build libpng. Instead of referencing the separate libpng repo, this adds png-sys as a subdirectory.
It uses build.rs for both png and png-sys, which is the preferred cargo method of building native dependencies.
It also updates libpng to the latest available version, which contains fixes for several security vulnerabilities.
Most importantly, it switches the FFI and native libs to prefix all symbols with RUST_ so that they don't conflict with symbols in other libraries, such as GTK.