Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix compilation issues with rustc 1.0.0-nightly #56
+56
−34
Conversation
Specifically, rustc 1.0.0-nightly (170c4399e 2015-01-14 00:41:55 +0000)
|
We have a branch that compiles with the 1.0 alpha - rustup_20150109. I'd prefer to rebase these changes on top of that branch and merge them in order. |
|
Haha, too bad I haven't noticed that earlier. Still, a nice learning exercise for me. Please disregard this PR, it only touches things already fixed in rustup_20150109. Thanks. |
|
Thanks for the PR, regardless :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
erszcz commentedJan 17, 2015
Specifically, rustc 1.0.0-nightly (170c4399e 2015-01-14 00:41:55 +0000)
I'm rather a rust newbie, so please let me know of any issues. Specifically, I'm not the happiest about repeating the match on
(color_type, pixel_width), but without that the compilation failed with:If there's a better way, I'm all ears.