Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issues with rustc 1.0.0-nightly #56

Closed
wants to merge 1 commit into from

Conversation

@erszcz
Copy link

erszcz commented Jan 17, 2015

Specifically, rustc 1.0.0-nightly (170c4399e 2015-01-14 00:41:55 +0000)

I'm rather a rust newbie, so please let me know of any issues. Specifically, I'm not the happiest about repeating the match on (color_type, pixel_width), but without that the compilation failed with:

src/lib.rs:133:41: 140:10 error: match arms have incompatible types:
 expected `(fn(collections::vec::Vec<u8>) -> PixelsByColorType {RGBA8}, _)`,
    found `(fn(collections::vec::Vec<u8>) -> PixelsByColorType {K8}, _)`

If there's a better way, I'm all ears.

Specifically, rustc 1.0.0-nightly (170c4399e 2015-01-14 00:41:55 +0000)
@jdm
Copy link
Member

jdm commented Jan 18, 2015

We have a branch that compiles with the 1.0 alpha - rustup_20150109. I'd prefer to rebase these changes on top of that branch and merge them in order.

@erszcz
Copy link
Author

erszcz commented Jan 18, 2015

Haha, too bad I haven't noticed that earlier. Still, a nice learning exercise for me. Please disregard this PR, it only touches things already fixed in rustup_20150109. Thanks.

@erszcz erszcz closed this Jan 18, 2015
@jdm
Copy link
Member

jdm commented Jan 18, 2015

Thanks for the PR, regardless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.