Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 16-bit chennels by stripping them to 8-bit. #57

Merged
merged 1 commit into from Jan 28, 2015
Merged

Conversation

@zarazek
Copy link
Contributor

zarazek commented Jan 22, 2015

This page: http://betterexplained.com/articles/linear-algebra-guide/ was causing Servo crash because of 16-bit grayscale images. Patch fixes this.

@zarazek
Copy link
Contributor Author

zarazek commented Jan 28, 2015

Hello! Anybody here?

@jdm
Copy link
Member

jdm commented Jan 28, 2015

Sorry about this; we've been swamped by upgrading Servo to use the 1.0 alpha. I'll find someone willing to sign off on this change.

@jdm
Copy link
Member

jdm commented Jan 28, 2015

Actually, having read http://www.libpng.org/pub/png/libpng-1.0.3-manual.html this change looks fine to me. Thanks!

jdm added a commit that referenced this pull request Jan 28, 2015
Handle 16-bit chennels by stripping them to 8-bit.
@jdm jdm merged commit ade2143 into servo:master Jan 28, 2015
@jdm
Copy link
Member

jdm commented Jan 28, 2015

Want to submit a PR to Servo as well that includes the result of ./mach update-cargo -p png --precise ade2143c96641abdaedd8bc556f45935d18c35df?

bors-servo pushed a commit to servo/servo that referenced this pull request Jan 29, 2015
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57
bors-servo pushed a commit to servo/servo that referenced this pull request Jan 30, 2015
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57

Source-Repo: https://github.com/servo/servo
Source-Revision: 06cedc8317663a71c06f0a2a482f2b4c3759b6be
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57

Source-Repo: https://github.com/servo/servo
Source-Revision: 06cedc8317663a71c06f0a2a482f2b4c3759b6be

UltraBlame original commit: 5a3604a4364f66785fee278ffd868876b0123937
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57

Source-Repo: https://github.com/servo/servo
Source-Revision: 06cedc8317663a71c06f0a2a482f2b4c3759b6be

UltraBlame original commit: 5a3604a4364f66785fee278ffd868876b0123937
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
Update to new version of PNG library. See earlier pull reqest for PNG lib: servo/rust-png#57

Source-Repo: https://github.com/servo/servo
Source-Revision: 06cedc8317663a71c06f0a2a482f2b4c3759b6be

UltraBlame original commit: 5a3604a4364f66785fee278ffd868876b0123937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.