Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize various code. #64

Merged
merged 5 commits into from Mar 21, 2015
Merged

Modernize various code. #64

merged 5 commits into from Mar 21, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 21, 2015

No description provided.

@Ms2ger Ms2ger force-pushed the modernize branch from cd609b0 to 9e12df0 Mar 21, 2015
src/lib.rs Outdated
image_data.offset += end_pos;
}
}

pub fn load_png(path: &Path) -> Result<Image,String> {
let mut reader = match File::open_mode(path, io::Open, io::Read) {
pub fn load_png<P: AsPath + ?Sized>(path: &P) -> Result<Image,String> {

This comment has been minimized.

Copy link
@Manishearth

Manishearth Mar 21, 2015

Member

nit: space between Image,String

@Manishearth
Copy link
Member

Manishearth commented Mar 21, 2015

r=me modulo one nit and rustup

Ms2ger added a commit that referenced this pull request Mar 21, 2015
Modernize various code; r=Manishearth
@Ms2ger Ms2ger merged commit 1d9c59c into master Mar 21, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Ms2ger Ms2ger deleted the modernize branch Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.