Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to build with 1.0.0-beta #67

Merged
merged 2 commits into from Apr 10, 2015
Merged

Updated to build with 1.0.0-beta #67

merged 2 commits into from Apr 10, 2015

Conversation

@lambdacat
Copy link

lambdacat commented Apr 4, 2015

The tests don't work, but that seems unavoidable since the test
feature is unstable (so extern crate test simply won't compile).

Sam Payson
The tests don't work, but that seems unavoidable since the `test`
feature is unstable (so `extern crate test` simply won't compile).
@jdm
Copy link
Member

jdm commented Apr 4, 2015

Looks likes

src/lib.rs:315:44: 315:54 error: use of unstable library feature 'convert': waiting on RFC revision
src/lib.rs:315             match load_png_from_memory(buf.as_slice()) {
                                                          ^~~~~~~~~~

would also prevent beta compatibility right now, right?

@metajack
Copy link
Contributor

metajack commented Apr 6, 2015

Comment out the #[bench] tests or remove them? The extern crate test seems only used for those. Or perhaps there is a stable formulation for benchmark tests we can use?

Sam Payson
@lambdacat
Copy link
Author

lambdacat commented Apr 7, 2015

According to the wisdom of the #rust irc channel, there is no beta-stable alternative at the moment. So I've commented out the benchmarks, and now the build is passing.

@jeffparsons
Copy link

jeffparsons commented Apr 10, 2015

FWIW I've just built and tested one of my toy projects (a local branch of https://github.com/slashgrin/lifelike updated to build with the 1.0.0beta rustc) against 6585178, and what little of the rust-png API I'm exercising appears to be working just fine.

@jdm
Copy link
Member

jdm commented Apr 10, 2015

Looks good to me!

jdm added a commit that referenced this pull request Apr 10, 2015
Updated to build with 1.0.0-beta
@jdm jdm merged commit 811e4d3 into servo:master Apr 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.