Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSpecify RANLIB for android builds #69
Merged
+2
−0
Conversation
When cross compiling from OSX to Android the build system for libpng would otherwise invoke the system `ranlib` on an android-targeting archive. This invocation would then corrupt the archive, preventing the compiler from working with it. By setting `RANLIB` to the android-specific `ranlib` tool the build system won't corrupt the archive, allowing rustc to read it and continue processing it.
|
This fixes the ICE on OSX along the lines of |
larsbergstrom
added a commit
that referenced
this pull request
May 7, 2015
Specify RANLIB for android builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alexcrichton commentedMay 7, 2015
When cross compiling from OSX to Android the build system for libpng would
otherwise invoke the system
ranlibon an android-targeting archive. Thisinvocation would then corrupt the archive, preventing the compiler from working
with it.
By setting
RANLIBto the android-specificranlibtool the build system won'tcorrupt the archive, allowing rustc to read it and continue processing it.