Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse vec! macro instead of iterator to initialise buffer #81
Conversation
The vec! macro is much faster than using `collect` to initialise a vector. This change decreases the run time of `load_png_from_memory` by 20%-30% on my machine.
notriddle
commented
Oct 13, 2016
|
Are we still maintaining this? I thought we switched to https://github.com/PistonDevelopers/image-png |
|
Sorry, I hadn't realised that this repo was unmaintained. Although I guess the date of the last commit should have tipped me off. |
|
Still, you made the PR, so I might as well merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fhartwig commentedOct 13, 2016
•
edited by larsbergstrom
The vec! macro is much faster than using
collectto initialise a vector.This change decreases the run time of
load_png_from_memoryby 20%-30%on my machine.
This change is