This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Drive-by breaking changes #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current impls in Servo NonTSPseudoClass cheap to clone (it’s a C-like enum) but as we add support for more pseudo classes (like :lang()) we will add variants that carry data that might be more expensive to clone.
It’s broken on current Rust versions (still uses the old compiler plugin) it nobody seems to use it since nobody noticed.
|
@bors-servo r+
|
|
📌 Commit 7c2387c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 6, 2017
Drive-by breaking changes Since we’re making a semver-incompatible version anyway (#104) here are a couple other breaking changes. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/105) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we’re making a semver-incompatible version anyway (#104) here are a couple other breaking changes.
This change is