Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMaybe remove the 'unreachable' crate dependency? #128
Closed
Comments
|
This would increase the minimum supported Rust version from 1.20 to 1.27. Since this crate is so widely used, we try to batch such changes together along with other breaking changes. Added this to the tracking bug (#73). |
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this issue
Feb 16, 2019
Fixes servo#128 by inlining the tiny amount of code we use from `unreachable` and its dependency `void`. Eventually this can be replaced with `std::hint::unrechable_unchecked` but this will require bumping our minumum supported Rust version. This will prevent build breakage from users building with broken versions of the `void` crate, as in crossbeam-rs/crossbeam#312.
bors-servo
added a commit
that referenced
this issue
Feb 16, 2019
Remove dependency on unmaintained 'unreachable' crate Fixes #128 by inlining the tiny amount of code we use from `unreachable` and its dependency `void`. Eventually this can be replaced with `std::hint::unrechable_unchecked` but this will require bumping our minumum supported Rust version. This will prevent build breakage from users building with broken versions of the `void` crate, as in crossbeam-rs/crossbeam#312. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/140) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rust-smallvec/lib.rs
Lines 48 to 49 in feb3e45
rust-smallvec/lib.rs
Line 762 in feb3e45
Seems like we might be able to replace this usage with this: