Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic-safety fixes #103

Merged
merged 2 commits into from Jul 19, 2018
Merged

Panic-safety fixes #103

merged 2 commits into from Jul 19, 2018

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 18, 2018

  • Make from_elem panic-safe. Fixes #101.
  • Make insert_many panic-safe. Fixes #96.

r? @SimonSapin or @jdm. cc @Vurich


This change is Reviewable

mbrubeck added 2 commits Jul 18, 2018
Fixes #101
@mbrubeck mbrubeck force-pushed the mbrubeck:panic branch from 54bc182 to 1f40252 Jul 18, 2018
@mbrubeck

This comment has been minimized.

Copy link
Contributor Author

mbrubeck commented Jul 18, 2018

Note: This PR also speeds up our insert_many benchmark by about 40%, and does not change the performance of our from_elem benchmarks.

@mbrubeck

This comment has been minimized.

Copy link
Contributor Author

mbrubeck commented Jul 18, 2018

The Travis failure is unrelated to this PR. It was caused by Rust nightly changes breaking the build when the unstable no_std support is enabled. Fixed by #104.

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jul 19, 2018

@bors-servo r+
I like the from_elem solution in particular.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jul 19, 2018

📌 Commit 1f40252 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jul 19, 2018

⌛️ Testing commit 1f40252 with merge 8fd2b9b...

bors-servo added a commit that referenced this pull request Jul 19, 2018
Panic-safety fixes

* Make from_elem panic-safe.  Fixes #101.
* Make insert_many panic-safe.  Fixes #96.

r? @SimonSapin or @jdm.  cc @Vurich

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/103)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jul 19, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 8fd2b9b to master...

@bors-servo bors-servo merged commit 1f40252 into servo:master Jul 19, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Jul 19, 2018
Changes in this release:

* Fix possible double-free in `insert_many` when passed an iterator that
  panics in `next` (servo#103)
* Add a new `union` feature (disabled by default) that reduces the size
  of the SmallVec struct (servo#94)
* Improve performance of `extend` and `from_elem` (servo#93)
* Improve performance of `drop` (servo#100)
* Update dev-dependency on `bincode` (servo#102)
* Update to build without `std` on current Rust nightly (servo#104)
* Additional benchmarks (servo#95, servo#97).
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Jul 19, 2018
Changes in this release:

* Fix possible double-free in `insert_many` when passed an iterator that
  panics in `next` (servo#103)
* Add a new `union` feature (disabled by default) that reduces the size
  of the SmallVec struct (servo#94)
* Improve performance of `extend` and `from_elem` (servo#93)
* Improve performance of `drop` (servo#100)
* Update dev-dependency on `bincode` (servo#102)
* Update to build without `std` on current Rust nightly (servo#104)
* Additional benchmarks (servo#95, servo#97).
@mbrubeck mbrubeck mentioned this pull request Jul 19, 2018
bors-servo added a commit that referenced this pull request Jul 19, 2018
Version 0.6.3

Changes in this release:

* Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (#103)
* Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (#94)
* Improve performance of `extend` and `from_elem` (#93)
* Improve performance of `drop` (#100)
* Update to build without `std` feature on current Rust nightly (#104)
* Additional benchmarks (#95, #97)
* Update dev-dependency on `bincode` (#102)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/105)
<!-- Reviewable:end -->
mbrubeck added a commit to mbrubeck/advisory-db that referenced this pull request Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.