Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd from_raw_parts. #130
Merged
Add from_raw_parts. #130
Conversation
|
Would it be better to unconditionally use |
|
Oh yeah I guess that wouldn't be safe, nvm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2018
Add from_raw_parts. I have a need to create a `SmallVec` using a heap allocation that I control. Something that works just like `Vec::from_raw_parts` fits the bill. The PR here adds a similar method, with the important difference that it panics if asked to conjure up a `SmallVec` that would use its inline storage rather than spilled, heap storage. This is a dependency of my work in https://bugzilla.mozilla.org/show_bug.cgi?id=1474793. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/130) <!-- Reviewable:end -->
|
|
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Nov 15, 2018
Merged
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Version 0.6.6 Changes in this release: * Fix possible over-allocation in `from_slice` (#122) * Optional nightly-only `specialization` feature for `from_slice` optimization (#123) * New `from_raw_parts` constructor (#130) * Documentation and testing improvements (#125, #129) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/131) <!-- Reviewable:end -->
|
Published: https://crates.io/crates/smallvec/0.6.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
heycam commentedNov 13, 2018
•
edited by larsbergstrom
I have a need to create a
SmallVecusing a heap allocation that I control. Something that works just likeVec::from_raw_partsfits the bill. The PR here adds a similar method, with the important difference that it panics if asked to conjure up aSmallVecthat would use its inline storage rather than spilled, heap storage.This is a dependency of my work in https://bugzilla.mozilla.org/show_bug.cgi?id=1474793.
This change is