Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new feature, `may_dangle`. #133

Merged
merged 2 commits into from Nov 29, 2018
Merged

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Nov 29, 2018

This commit adds a may_dangle annotation to drop, matching Vec.
This feature increases the ability of SmallVec to be used as a drop-in
replacement for Vec. A feature is necessary because may_dangle is
Nightly-only.

Fixes #132.


This change is Reviewable

nnethercote added 2 commits Nov 21, 2018
This commit adds a `may_dangle` annotation to `drop`, matching `Vec`.
This feature increases the ability of `SmallVec` to be used as a drop-in
replacement for `Vec`. A feature is necessary because `may_dangle` is
Nightly-only.

Fixes #132.
@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 29, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2018

📌 Commit 72a500f has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2018

Testing commit 72a500f with merge e244d0a...

bors-servo added a commit that referenced this pull request Nov 29, 2018
Add a new feature, `may_dangle`.

This commit adds a `may_dangle` annotation to `drop`, matching `Vec`.
This feature increases the ability of `SmallVec` to be used as a drop-in
replacement for `Vec`. A feature is necessary because `may_dangle` is
Nightly-only.

Fixes #132.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/133)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2018

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing e244d0a to master...

@bors-servo bors-servo merged commit 72a500f into servo:master Nov 29, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 29, 2018

@nnethercote nnethercote deleted the nnethercote:may_dangle branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.