-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move use of 'default fn' to its own module #161
Conversation
Can you elaborate? Why is it the right way, or better than the current code? This moves one of the specialized functions to its own module, but not the rest, so now you need to look at two different files that interact with each other. |
The way this is encoded right now assumes that rustc's parser will always be able to parse |
That seems like a pretty common footgun, isn't it? Is that something that rustc should warn about somehow? |
Not that common I think but I'm working on doing more pre-expansion gating so you don't get into this situation in most cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can't stamp it, though not in love with this :)
@bors-servo r+ |
📌 Commit 92122e2 has been approved by |
Move use of 'default fn' to its own module This is the proper way to do `cfg(...)` gating when dealing with an unstable feature that introduces syntax. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/161) <!-- Reviewable:end -->
☀️ Test successful - checks-travis |
* Move code using specialization into its own module (#161)
This is the proper way to do
cfg(...)
gating when dealing with an unstable feature that introduces syntax.This change is