Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse no_std by default #173
Merged
Conversation
The `std` feature is only needed to enable `impl Write for SmallVec`, which most users of this crate do not need. This patch replaces the enabled-by-default `std` feature with a disabled-by-default `write` feature. This decreases the chance that users of this crate will accidentally depend on libstd when they don't need it.
|
r? @emilio |
|
Looks good! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 29, 2019
Use no_std by default Since `alloc` became stable, the `std` feature is only needed to enable `impl Write for SmallVec`, which most users of this crate do not need. This patch replaces the enabled-by-default `std` feature with a disabled-by-default `write` feature. This decreases the chance that users of this crate will accidentally depend on libstd when they don't need it.
|
|
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Oct 30, 2019
* [breaking change] Use `MaybeUninit` internally to avoid possible undefined behavior (servo#162, servo#170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (servo#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (servo#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8, _]>` can implement the `std::io::Write` trait (servo#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (servo#163). * Iterators now implement `FusedIterator` (servo#172). * Indexing now uses the standard `SliceIndex` trait (servo#166). * Remove the deprecated `VecLike` trait (servo#165). * Use `NonNull` internally (servo#171). * Add automatic fuzz testing and MIRI testing (servo#168, servo#162). * Update syntax and formatting to Rust 2018 standard (servo#174, servo#167).
Merged
bors-servo
added a commit
that referenced
this pull request
Nov 2, 2019
Version 1.0.0 * Requires Rust 1.36 or later. * [breaking change] Use `MaybeUninit` to avoid possible undefined behavior (#162, #170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8;_]>` can implement the `std::io::Write` trait (#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163). * Iterators now implement `FusedIterator` (#172). * Indexing now uses the standard `SliceIndex` trait (#166). * Remove the deprecated `VecLike` trait (#165). * Use `NonNull` internally (#171). * Add automatic fuzz testing and MIRI testing (#168, #162). * Update syntax and formatting to Rust 2018 standard (#174, #167).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedOct 29, 2019
•
edited
Since
allocbecame stable, thestdfeature is only needed to enableimpl Write for SmallVec, which most users of this crate do not need. This patch replaces the enabled-by-defaultstdfeature with a disabled-by-defaultwritefeature. This decreases the chance that users of this crate will accidentally depend on libstd when they don't need it.