Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVersion 1.0.0 #175
Merged
Version 1.0.0 #175
Conversation
* [breaking change] Use `MaybeUninit` internally to avoid possible undefined behavior (#162, #170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8, _]>` can implement the `std::io::Write` trait (#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163). * Iterators now implement `FusedIterator` (#172). * Indexing now uses the standard `SliceIndex` trait (#166). * Remove the deprecated `VecLike` trait (#165). * Use `NonNull` internally (#171). * Add automatic fuzz testing and MIRI testing (#168, #162). * Update syntax and formatting to Rust 2018 standard (#174, #167).
|
@emilio Any feedback on this? |
|
I'm ok with this. Not sure if we should wait more to get to 1.0, I don't have strong opinions on that :) |
|
I found @mbrubeck's reasoning in #73 (comment) compelling. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 2, 2019
Version 1.0.0 * Requires Rust 1.36 or later. * [breaking change] Use `MaybeUninit` to avoid possible undefined behavior (#162, #170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8;_]>` can implement the `std::io::Write` trait (#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163). * Iterators now implement `FusedIterator` (#172). * Indexing now uses the standard `SliceIndex` trait (#166). * Remove the deprecated `VecLike` trait (#165). * Use `NonNull` internally (#171). * Add automatic fuzz testing and MIRI testing (#168, #162). * Update syntax and formatting to Rust 2018 standard (#174, #167).
|
|
bors bot
added a commit
to Amanieu/parking_lot
that referenced
this pull request
Nov 4, 2019
188: Bump smallvec version to 1.0 r=Amanieu a=messense See servo/rust-smallvec#175 for changelog Co-authored-by: messense <messense@icloud.com>
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 6, 2019
bump smallvec to 1.0 This includes servo/rust-smallvec#162, fixing an unsoundness in smallvec. See servo/rust-smallvec#175 for the 1.0 release announcement. Cc @mbrubeck @emilio
This was referenced Nov 9, 2019
aardappel
added a commit
to google/flatbuffers
that referenced
this pull request
Nov 11, 2019
See servo/rust-smallvec#175 for changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedOct 30, 2019
•
edited
MaybeUninitto avoid possible undefined behavior (#162, #170).drainmethod now takes a range argument, just like the standardVec::drain(#145).unreachablefunction and replace it with the new standardunreachable_uncheckedfunction (#164).no_stdby default. This crate depends only oncoreandallocby default. If the optionalwritefeature is enabled then it depends onstdso thatSmallVec<[u8;_]>can implement thestd::io::Writetrait (#173).SmallVec<[T; 96]>(#163).FusedIterator(#172).SliceIndextrait (#166).VecLiketrait (#165).NonNullinternally (#171).