Backport MaybeUninit changes to 0.6 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of servo#162 to the smallvec 0.6 branch. To avoid bumping the minimum Rust version, the `maybe-uninit` crate is used in place of `std::mem::MaybeUninit`. To avoid breaking changes, the `Array::ptr` and `ptr_mut` methods are retained but are no longer used, and the API to `from_buf_and_len_unchecked` is unchanged.
Works now on trunk. Closes servo#139
mbrubeck
force-pushed
the
maybe_uninit
branch
from
be00e0c
to
58d5416
Compare
|
Awesome, thanks. :) What does your release schedule look like? (I exempted arrays from rust-lang/rust#66059 for now to give smallvec users some more time.) |
|
Published version 0.6.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #162 and #170 to the smallvec 0.6 branch. To avoid bumping the minimum Rust version, the
maybe-uninitcrate is used in place ofstd::mem::MaybeUninit. To avoid breaking changes, theArray::ptrandptr_mutmethods are retained but are no longer used, and the API tofrom_buf_and_len_uncheckedis unchanged.